Revision history [back]

Tones found the answer (above) - good find Tones! However, the code was never updated, and the wiki was changed incorrectly (cited wrong line)) I pushed a change which has been merged and which fixes the problem. I've repaired the incorrect wiki changes by now telling what has to change in case you're on an earlier version than that when the API changed. Here's the commit comment:

Fix wrong order of arguments to q.setRPY in commit 82964f6.
The API shows the order is:
void    setRPY (const tfScalar &roll, const tfScalar &pitch, const tfScalar 

Line 14 should read:

q.setRPY(0, 0, msg->theta);

This fault breaks this tutorial:

http://wiki.ros.org/tf/Tutorials/Writing%20a%20tf%20broadcaster%20%28C%2B%2B

In a way that doesn't show up until the subsequent tutorial, where the
follower doesn't follow. The fix to line 14 proposed above fixes the
subsequent tutorial.

The problem is discussed in this thread:

http://answers.ros.org/question/45884/turtle-tf-tutorial-fails-to-work/?answ

and an incorrect fix was applied to the wiki. The note in the wiki under
the code, which says the code should read:

transform.setRotation( tf::Quaternion(0, 0, msg->theta) );

is wrong - it should say q.setRPY.

Tones found the answer (above) - good find Tones! However, the code was never updated, and the wiki was changed incorrectly (cited wrong line)) I pushed a change which has been merged and which fixes the problem. I've repaired the incorrect wiki changes by now telling what has to change in case you're on an earlier version than that when the API changed. Here's the commit comment:comment (in part - edited for clarity):

Fix wrong order of arguments to q.setRPY in commit 82964f6.
The API shows the order is:
void    setRPY (const tfScalar &roll, const tfScalar &pitch, const tfScalar 

Line 14 should read:

q.setRPY(0, 0, msg->theta);

This fault breaks this tutorial:

http://wiki.ros.org/tf/Tutorials/Writing%20a%20tf%20broadcaster%20%28C%2B%2B

In a way that doesn't show up until the subsequent tutorial, where the
follower doesn't follow. The fix to line 14 proposed above fixes the
subsequent tutorial.

The problem is discussed in this thread:

http://answers.ros.org/question/45884/turtle-tf-tutorial-fails-to-work/?answ

and an incorrect fix was applied to the wiki. The note in the wiki under
the code, which says the code should read:

transform.setRotation( tf::Quaternion(0, 0, msg->theta) );

is wrong - it should say q.setRPY.
reference q.setRPY(), but in any case, should talk about the earlier version where mst->theta is the first argument, since the code has now been repaired.