rosserial on noetic, bug report
Hello,
While using rosserial on noetic, with a device I built, I observed that rosserial client can not send stop tx request.
Here is the problematic part:
def txStopRequest(self):
""" Send stop tx request to client before the node exits. """
if not self.fix_pyserial_for_test:
with self.read_lock:
self.port.flushInput()
rospy.loginfo("Sending tx stop request..")
self.write_queue.put(self.header + self.protocol_ver + b"\x00\x00\xff\x0b\x00\xf4")
rospy.loginfo("Sending tx stop request")
When the user presses CTRL+C on the console, if using melodic, the rosserial device stops. But if using noetic, the rosserial device will continue to think it is still connected.
I have compared code side by side for SerialClient.py and node_handle.h
For some reason, SerialClient.py sends the stop request, but this does not get processed by the rosserial device.
Any ideas/help/recomendations greatly appreciated.
PS: also where should i report this bug?
Best regards, C.A.
I would file a bug report. . Even better, try to fix the issue and send a pull request.
done. I fixed it and sent a pull request.
Link: ros-drivers/rosserial#551.